D28765: KSettings::Dialog: add support for KPluginInfos without a KService

[Ahmad Samir]

ahmadsamir added a comment.


  systemsettings uses KCModuleInfo::service() to check whether the moduleinfo is valid[1], the problem is creating a KPluginInfo from the KService based on a .desktop file with X-KDE-ServiceTypes=SystemSettingsExternalApp fails because it doesn't seem to have valid metadata. Since the KPluginInfo ctor fails, accessing d->pluginInfo.service() causes a crash, I've submitted a proposed fix at [2]. This doesn't fix the bug, but merely prevents the crash.
  
  [1] https://invent.kde.org/plasma/systemsettings/-/blob/master/core/ModuleView.cpp#L229
  [2] https://invent.kde.org/frameworks/kcmutils/-/merge_requests/1

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela
Cc: ahmadsamir, rikmills, wbauer, kossebau, svuorela, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200520/6111fbbe/attachment.htm>