D29381: Thumbnail text: use libmagic to detect encoding

Méven Car noreply at phabricator.kde.org
Tue May 19 17:44:49 BST 2020


meven added a comment.


  I am only half satisfied by the patch.
  Mostly because of libmagic `magic_load` that loads a 5M file each time which is not needed to detect encoding.
  
  I would add some tests before landing anyways.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29381

To: meven, #frameworks, sitter, ngraham
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200519/f91f7ab5/attachment.htm>


More information about the Kde-frameworks-devel mailing list