D29805: Thumbnail djvu: avoid to exit(1) when it should not
Pino Toscano
noreply at phabricator.kde.org
Sun May 17 08:51:57 BST 2020
pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.
Please update the text of the revision and the commit message, as they don't make much sense. Please mention that it fixes a crash in case ddjvu is not installed, by avoiding executing it, and using _exit() to not run atexit handlers in case execvp() fails.
Also, please respect the indentation of the code: 2 spaces, and no brackets for a single instruction in a block.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D29805
To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200517/1925a08d/attachment.htm>
More information about the Kde-frameworks-devel
mailing list