D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )
Carson Black
noreply at phabricator.kde.org
Sat May 16 18:40:16 BST 2020
cblack added a comment.
In D29797#672263 <https://phabricator.kde.org/D29797#672263>, @kossebau wrote:
> Thanks for the (first) review :)
>
> Open questions I have are these:
> a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallback to load() otherwise? It was only introduced at a certain version of pyyaml
> b) by supposedly breaking support for Python 2, how to properly catch any usage of python2 now?
Best thing to do would be a follow-up patch that uses python3 shebangs. But frankly, I wouldn't care about Python 2. It's been EOL for half a year now and people have had more than enough time to migrate to Python 3.
REPOSITORY
R264 KApiDox
BRANCH
makedepworkwithpython3
REVISION DETAIL
https://phabricator.kde.org/D29797
To: kossebau, #frameworks, ochurlaud, ognarb, cblack
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200516/870c6bc2/attachment.htm>
More information about the Kde-frameworks-devel
mailing list