D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs
Ahmad Samir
noreply at phabricator.kde.org
Sat May 16 17:22:43 BST 2020
ahmadsamir added a comment.
In D29782#672157 <https://phabricator.kde.org/D29782#672157>, @dfaure wrote:
> Can you add a unittest for a KIO::mostLocalUrl() in testtrash.cpp (which is :local, so it should work)
I don't see where the trash ioslave sets UDS_LOCAL_PATH; I think it doesn't set it, I could be wrong, though.
> and another one in jobtest.cpp for a http URL (e.g. to test which error code we're getting, if any?)
I'll look into that next.
> + call mostLocalUrl() on a "normal" StatJob in testtrash.cpp
Same as the first point :)
[...]
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D29782
To: ahmadsamir, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200516/18a7514d/attachment-0001.htm>
More information about the Kde-frameworks-devel
mailing list