D25339: update lineHeight if boundingRect indicates a larger value.

[Xuetian Weng]

xuetianweng added a comment.


  Actually I was trying to use this approach in the patch because I was afraid that variable line height may need to estimate the whole document height to make scroll work correctly.
  
  But during this patching experience I realized that the ktexteditor first line is always a whole line. So the renderer only need to care about the current page instead of whole document, which makes variable line height might not as hard as thought.
  
  I won't have time recently to look into the variable line height though.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200515/d5d57e18/attachment.htm>