D29782: [StatJob] Change mostLocalUrl to only handle protocols with Class=:local

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, sitter.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Previously mostLocalUrl would check that !url.isLocalFile(), that meant
  a statjob would be fired for remote urls, such urls will never have a
  mostLocalUrl. Instead check for protocols with Class=:local.
  
  For a list of such protocols: `grep :local /usr/share/kservices5/*.protocol`
  
  Thanks to sitter for figuring it out in the bug report.
  
  BUG: 420985
  FIXED-IN: 5.71

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-most-local-url-local (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29782

AFFECTED FILES
  src/core/statjob.cpp
  src/core/statjob.h

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200515/7f666527/attachment-0001.htm>