D29742: Avoid potential disconnect of all signals in IconItem

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  m_svgIcon can be null.
  
  disconnect(q, nullptr, nullptr, nullptr); would have pretty catastrophic
  consequences as it disconnects everything. Anyone listening for
  QObject::destroyed of IconItem for cleanup would no longer get anything.
  That could lead to obscure conditions.
  
  ShaderEffectSource watches for the source being destroyed for cleanup
  and we have a newly introduced crash with ShaderEffectSource that seems
  to come from this patch.
  
  CCBUG: 421170

TEST PLAN
  Uploading for someone to reproduce to test

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29742

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200514/a28013fb/attachment.htm>