D29634: sftp: break large writes into multiple requests
Méven Car
noreply at phabricator.kde.org
Thu May 14 08:45:20 BST 2020
meven added a comment.
In D29634#670485 <https://phabricator.kde.org/D29634#670485>, @feverfew wrote:
> In D29634#670419 <https://phabricator.kde.org/D29634#670419>, @meven wrote:
>
> > In D29634#670377 <https://phabricator.kde.org/D29634#670377>, @ngraham wrote:
> >
> > > Nice work.
> > >
> > > In D29634#670159 <https://phabricator.kde.org/D29634#670159>, @feverfew wrote:
> > >
> > > > I imagine something similar should be done for FileJob::write?
> > >
> > >
> > > Yeah.
> >
> >
> > I guess you meant `FileProtocol::write`.
> > There is no need there, it uses `QIODevice::write` directly.
>
>
> Sorry, I meant `kio_sftp`'s implementation of this: https://api.kde.org/frameworks/kio/html/classKIO_1_1FileJob.html#a481871536fb9471ccb64929792f31165
I believe this is taken care of this patch in `SFTPInternal::write`
REPOSITORY
R320 KIO Extras
BRANCH
release/20.04
REVISION DETAIL
https://phabricator.kde.org/D29634
To: sitter, ngraham, meven, feverfew
Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200514/8c4da0d5/attachment.htm>
More information about the Kde-frameworks-devel
mailing list