D29201: KCMUtils: Add option to append service file to list of arguments

Alexander Lohnau noreply at phabricator.kde.org
Wed May 13 09:14:22 BST 2020


alex added inline comments.

INLINE COMMENTS

> meven wrote in kpluginselector.cpp:855
> Adding a fileName field to KCModuleProxy would make more sense to me, and do it by default.
> Plus KCModuleProxy has already access to the fileName since it receives moduleInfo. 
> But I am not a specialist.

You could add a field to the KCModule class (thats where you ultimately want to access the fileName).
But then the downside is that you don't have them as a constructor argument.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200513/a62f049a/attachment.htm>


More information about the Kde-frameworks-devel mailing list