D27203: Don't try to open files we can't figure out where they are

David Faure noreply at phabricator.kde.org
Mon May 11 23:41:09 BST 2020


dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:226
> +    //passing non-local files as the working directory is not supported.
> +    //See QFileDialogPrivate::initialSelections
> +    //Selectingg files should be done through the correct method.

That's not what that method says. It just says it can't know if the initial *selection* is a file or directory.

That's unrelated to what is the start directory.

QFileDialogPrivate::workingDirectory does support remote dirs.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200511/d77eeb17/attachment.htm>


More information about the Kde-frameworks-devel mailing list