D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis added inline comments.

INLINE COMMENTS

> cfeck wrote in kcolorcombo.h:61
> The comment still says "struct". Maybe clarify that this list is actually used as a map.
> 
> (I guess since mapping would happen in both directions, using a QMap isn't useful?)

Using QMap would cause me a problem, consider the following code block:

  for (int i = 0; i <STANDARD_PALETTE_SIZE; ++ i) {
                   if (standardColor (i) == color) {
                       q-> setCurrentIndex (i + 1);

I need variable i for iteration with the call q-> setCurrentIndex (i + 1) and this method would not be available with QMap.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200511/fe6a1380/attachment-0001.htm>