D29610: [CopyJob] Use stricter conditions when using QFile::rename in slotResultRenaming

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  The code now uses QFile::rename() only if direct renaming fails and we're
  moving a file/dir e.g. 'A' to 'a' on a case-insensitive filesystem such
  as FAT3. This matches the behaviour from before commit cb89bab36a5aa4e78c <https://phabricator.kde.org/R241:cb89bab36a5aa4e78c10b0e88d5f91d4d1a5267a>,
  and also fixes the jobtest moveFileDestAlreadyExists unit test.

TEST PLAN
  jobtest unit test passes again
  Moving a dir 'A' to 'a' on a FAT32 partition still works

REPOSITORY
  R241 KIO

BRANCH
  l-qfile-rename (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29610

AFFECTED FILES
  src/core/copyjob.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200510/6ed6a366/attachment-0001.htm>