D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

[David Faure]

dfaure created this revision.
dfaure added reviewers: ahmadsamir, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This will not look up the preferred app or run scripts/executables, it always shows an open-with dialog.
  Bonus feature compared to KRun::displayOpenWithDialog or KOpenWithDialog: it will first determine the mimetype
  (even for remote URLs), which allows to "remember this app for this mimetype".
  
  On the other hand, this loses the support for multiple URLs; OpenUrlJob is about a single URL.
  I guess for multiple URLs the best solution is to use KOpenWithDialog directly.

TEST PLAN
  New unittest

REPOSITORY
  R241 KIO

BRANCH
  2020_05_displayOpenWithDialog

REVISION DETAIL
  https://phabricator.kde.org/D29558

AFFECTED FILES
  autotests/openurljobtest.cpp
  autotests/openurljobtest.h
  src/gui/openurljob.cpp
  src/gui/openurljob.h

To: dfaure, ahmadsamir, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200509/ff434311/attachment.htm>