D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked 7 inline comments as done.
araujoluis added inline comments.

INLINE COMMENTS

> tcanabrava wrote in kcolorcombo.cpp:244
> namedColors.reserve(colors.size());

Done!

> tcanabrava wrote in kcolorcombo.cpp:245
> for(auto color : colors)

Done!

> tcanabrava wrote in kcolorcombo.cpp:288
> why is there a for running with all code comented out?

Done!

> tcanabrava wrote in kcolorcombo.h:60
> QPair<QString, QColor> - no need for a struct.

Done!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200508/ac0db29c/attachment-0001.htm>