D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Sorry, I have one last comment about a comment :)

INLINE COMMENTS

> copyjob.cpp:477
> +            // Check available free space for remote urls
> +            // TODO: find a way to report connection errors to the user
> +            KIO::FileSystemFreeSpaceJob *spaceJob = KIO::fileSystemFreeSpace(existingDest);

This comment is now completely out of context. It used to be about NFS/SMB, now this information has gone and one is left wondering why kind of connections we're talking about (connection to the kioslave???)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200508/59062de1/attachment.htm>