D29511: Label: Add ping-pong logic
David Edmundson
noreply at phabricator.kde.org
Thu May 7 17:06:03 BST 2020
davidedmundson requested changes to this revision.
davidedmundson added a comment.
Plasmacomponents is deprecated please see Plasmacomponents3 then see the readme within that and put this somewhere else.
1. Label is a super super super common element we don't want to add any overhead instantiating a label. A new special class would be best
2. It can all be done in one SequentialAnimation, you don't need states.
3. You don't need to get the width again, we know this already from the other text properties.
4. This is broken for any text that's wrapped or elided
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D29511
To: patrickelectric, #plasma, #vdg, ognarb, davidedmundson
Cc: davidedmundson, ognarb, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200507/00d1ea72/attachment.htm>
More information about the Kde-frameworks-devel
mailing list