D29485: [CopyJob] Check free space for remote urls before copying and other improvements

Ahmad Samir noreply at phabricator.kde.org
Wed May 6 16:30:36 BST 2020


ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Use KIO::FileSystemFreeSpaceJob to check free space for remote urls.
  
  Thanks to sitter for pin-pointing the responsible code in the bug report,
  and to kbroulik for pointing out the existence of KIO::FileSystemFreeSpaceJob.
  
  Also use UDSEntry to check writability for both local and remote urls.
  
  BUG: 418443
  
  FIXED-IN: 5.71

TEST PLAN
  testtrash unit test fails (again...)
  
  - Find/create a local partition with a small capacity, copying a file/dir that is bigger than the partition will show the error message as before
  - Do the same for a remote url (I tested with sftp://), an error message about not having enough free space is shown

REPOSITORY
  R241 KIO

BRANCH
  l-freespace-remote-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29485

AFFECTED FILES
  src/core/copyjob.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200506/7ea06146/attachment.html>


More information about the Kde-frameworks-devel mailing list