D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven marked 2 inline comments as done.
meven added a comment.


  I have pretty much the patch in kio-extras ready.
  So I am seeking

INLINE COMMENTS

> broulik wrote in previewjob.cpp:433
> Not a fan. You can have different dpi per screen.
> Maybe instead we should have a `QWindow*` method or constructor to take dpr from

> Not a fan. You can have different dpi per screen.

What you imply is incorrect.
In Wayland, QGuiApplication::devicePixelRatio always returns the maximum scale of any screens (and ceiled up, so my 1.25 scale is returned as 2), and always the same value regardless on the scale of the screen where the app is. Only at painting does the scale makes a difference per screen.

In X, well there is only one scale anyway.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200506/1d72f84a/attachment-0001.html>