D29447: Fix showing updates when the option is selected

Alexander Lohnau noreply at phabricator.kde.org
Tue May 5 20:06:40 BST 2020


alex added inline comments.

INLINE COMMENTS

> itemsmodel.cpp:71
> +    bool duplicate{false};
> +    for (const EntryInternal &existingEntry : qAsConst(m_entries)) {
> +        if (existingEntry == entry) {

On second thought why not just use:
`bool duplicate =  m_entries.contains(entry);`

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-show-only-updates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29447

To: leinir, #knewstuff, #plasma, bugseforuns, ngraham, #frameworks
Cc: alex, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200505/b9c23e26/attachment.html>


More information about the Kde-frameworks-devel mailing list