D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kopenwithdialog.cpp:1006
>          // Ensure that the typed binary name actually exists (#81190)
>          if (QStandardPaths::findExecutable(binaryName).isEmpty()) {
> +            // Maybe it exists but isn't executable

This patch D29170 <https://phabricator.kde.org/D29170> suggests that findExecutable won't find non-executables.

Something's wrong.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29445

To: broulik, #frameworks, #vdg
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200505/bc0d1cf4/attachment.html>