D29405: [PoC] Make notifications work without a notifyrc file
Nicolas Fella
noreply at phabricator.kde.org
Mon May 4 14:15:26 BST 2020
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
In KNotificationManager when reading the actions default to Popup when no actions are found. In notifybypopup default to QGuiApplication::applicationDisplayName() when reading the app name. The logic for the icon is not changed, worst case we get empty which may get overridden by the user.
Other backends are still todo
TEST PLAN
Deleted notifyrc file from KDE Connect. Still get notifications. As a side effect the pairing notification now shows "KDE Connect Daemon" instead of "KDE Connect". This could be changed with a new setter or x-kde-display-appname
REPOSITORY
R289 KNotifications
BRANCH
nonotifyrc
REVISION DETAIL
https://phabricator.kde.org/D29405
AFFECTED FILES
src/knotificationmanager.cpp
src/notifybypopup.cpp
To: nicolasfella, #frameworks, broulik, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200504/41991cf5/attachment.html>
More information about the Kde-frameworks-devel
mailing list