D29390: Respect QIcon::fallbackSearchpaths()

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> aacid wrote in kiconloader.cpp:1142
> Would it make sense trying to use QIconLoader::lookupFallbackIcon ? This way we "upstream" Qt behaviour? For example you're supporting svgz while Qt doesn't. Which would mean different QIcon::fallbackSearchPaths whether you're using KIconLoader or not which doesn't seem totally great?

I just realized that function is private, not really easy to use :/

anyhow do you think we should remove svgz?

Also i think using

const QStringList extensions = { QStringLiteral(".png"), QStringLiteral(".svg"), QStringLiteral(".svgz"), QStringLiteral(".xpm") };

should be a bit faster

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29390

To: nicolasfella, #plasma, #frameworks
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200503/31e9b193/attachment.html>