D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme
Filip Fila
noreply at phabricator.kde.org
Fri May 1 22:49:29 BST 2020
filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.
REVISION SUMMARY
We're the only theme with the appropriate heading svgs that make the headers and footers look as they should.
All the other themes fall back to Breeze, which is not a good look for some of them:
- the heading is too jarring compared to applet background
- the heading does not extend all the way vertically and horizontally
To solve this, to avoid degrading unmaintained themes and to give themes a chance to adjust on their own terms, this patch makes the heading visible only when the needed SVG exists in the theme.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
heading-only-if-svg-exists (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29352
AFFECTED FILES
src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
To: filipf
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200501/0b7b1b61/attachment.html>
More information about the Kde-frameworks-devel
mailing list