D29175: DBus Runner: Add service property to request actions once
Méven Car
noreply at phabricator.kde.org
Fri May 1 17:56:29 BST 2020
meven added inline comments.
INLINE COMMENTS
> dbusrunnertest.cpp:204
> + // We haven't called the prepare slot, if the implementation works
> + // the actions should alredy be available
> + auto actions = m.actionsForMatch(fakeMatch);
typo: already
> dbusrunnertest.cpp:206
> + auto actions = m.actionsForMatch(fakeMatch);
> + QCOMPARE(actions.count(), 1);
> +
You should have added a QSignalSpy to check prepare was called, and another for requestAction to check it has been called only once.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D29175
To: alex, #plasma, meven, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200501/eb7dd368/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list