D29335: Implement notification grouping on Android

Volker Krause noreply at phabricator.kde.org
Fri May 1 15:39:45 BST 2020


vkrause added inline comments.

INLINE COMMENTS

> nicolasfella wrote in NotifyByAndroid.java:171
> Please use https://developer.android.com/reference/android/os/Build.VERSION_CODES instead of hardcoding numbers

That seems counter-productive to me, as the Android API documentation always speaks about API level numbers, so you'd need to do an additional translation to/from the letters in your head. So for that I find "26" more useful here than "O". It's also consistent with the rest of the code in this file.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29335

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200501/6b26b7fe/attachment.html>


More information about the Kde-frameworks-devel mailing list