D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

[Benjamin Port]

bport requested changes to this revision.
bport added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfontchooser.cpp:347
>  
>      // Completed the font attributes grid
>  

This comment is still valid ?

> kfontchooser.cpp:381
> +    if (flags & ShowDifferences) { // In this mode follow the state of the familyCheckbox
> +        connect(familyCheckbox, &QAbstractButton::toggled, q, [this](const bool state) {
> +            onlyFixedCheckbox->setEnabled(state);

I think there you can connect directly to setEnabled, you don't need a lambda

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28274

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200331/81520cb1/attachment-0001.html>