D28266: KPropertiesDialog: port KRun::run to ApplicationLauncherJob

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Also +1 for porting to kservice rather than launching binary

INLINE COMMENTS

> applicationlauncherjob.h:50
>   *
> + * For error handling, either connect to the result() signal, or for a simple messagebox on error,
> + * you can do

Please add this in a separate commit

> kpropertiesdialog.cpp:1458
> +        job->setUrls({ properties->url() });
> +        job->start();
> +        auto *delegate = new KDialogJobUiDelegate;

Call this after setting everything up?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28266

To: dfaure, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200329/e3f4b221/attachment.html>