D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta requested changes to this revision.
usta added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jobtest.cpp:500
> +
> +    QProcess xattrwriter;
> +    xattrwriter.setProcessChannelMode(QProcess::MergedChannels);

aren't we using camelcase rules for variables in kde ? is so xattrwriter => xattrWriter

> jobtest.cpp:531
> +
> +    QProcess xattrreader;
> +    xattrreader.setProcessChannelMode(QProcess::MergedChannels);

camelCase ?  xattrreader => xattrReader

> file_unix.cpp:167
> +    // Linux and MacOS return = list of null terminated string, each string = [data,'\0']
> +    // BSD return = list of itens, each item prepended of 1 byte size = [size, data]
> +

small typo in comment : itens => items

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200329/c95b0ac9/attachment-0001.html>