D17816: Support for xattrs on kio copy/move
Cochise César
noreply at phabricator.kde.org
Sun Mar 29 00:46:22 GMT 2020
cochise marked an inline comment as done.
cochise added inline comments.
INLINE COMMENTS
> dfaure wrote in file_unix.cpp:179
> Ah, I see, you still need to call `strlen()` yourself, for the code at the end of the iteration....
>
> Well, then you might as well pass the value to the constructor so it doesn't need to do the same.
>
> const QByteArray key(keyPtr, keyLen);
>
> after the #endif, since it would now be the exact same line of code for both cases.
This look really better.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17816
To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200329/cb84ecca/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list