D28390: KIO: remove waitForStarted() from the launcher jobs public API

[David Faure]

dfaure created this revision.
dfaure added reviewers: davidedmundson, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This only exists for KRun. I don't want apps to start using that.
  We have to be able to remove waitForStarted() in KF6 so that we can do other
  async things before starting the process (like resolving URLs, making async dbus
  calls for FUSE stuff etc.)
  
  - Rename KRun::KRunPrivate to KRunPrivate so that we can declare it as friend in the job classes
  - Move two file-static methods in krun.cpp into the KRunPrivate class so they benefit from this

TEST PLAN
  It builds

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28390

AFFECTED FILES
  src/gui/applicationlauncherjob.h
  src/gui/commandlauncherjob.h
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/krun_p.h

To: dfaure, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200328/067896f9/attachment.html>