D28302: [KNewFileMenu] Add extension to proposed filename

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Thanks for all your work, I'm impressed!

INLINE COMMENTS

> knewfilemenu.cpp:464
> +    // Prompt the user to set the destination filename, and initially display
> +    // the filename from the template including the extenstion, e.g. "TextFile.txt",
> +    // "HTMLFile.html" in the line edit

typo: extenstion -> extension

> knewfilemenu.cpp:466
> +    // "HTMLFile.html" in the line edit
> +    QString text = entry.templatePath;
> +    text = text.mid(text.lastIndexOf(QLatin1Char('/')) + 1);

The old code was using a translated string as suggested file name.
You're using a filename that it going to be always in English.

How about appending the extension from templatePath to the translated text?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28302

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200328/29ba1801/attachment.html>