D28355: Introduce function ecm_install_configured_file

Pino Toscano noreply at phabricator.kde.org
Fri Mar 27 23:58:35 GMT 2020


pino added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ECMConfiguredInstall.cmake:46-48
> Maybe.
> 
> My rationale for not forcing a suffix is sometimes we do this configure dance for .desktop files and there we have to be a bit careful with scripty.
> 
> But generally it's neater and easier to use when a suffix is used. Currently Plasma is all over the place with what suffix to have, so I picked one at random.

No problem either way. My idea is that if a precise suffix is required, then setting it //before// this function is merged is better, otherwise doing it once it is already in use means breaking potential (mis)users.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200327/38c4f9bc/attachment.html>


More information about the Kde-frameworks-devel mailing list