D28324: [Inotify] Remove dead/duplicate code
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Fri Mar 27 17:26:21 GMT 2020
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> pino wrote in kinotify.cpp:350
> then add an assert for this case, referencing the documentation?
asserts are IMHO pointless, nobody enables them, but it clutters the code. Anyone touching the code should and has to read the man pages etc anyway.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D28324
To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200327/33fc1ec8/attachment.html>
More information about the Kde-frameworks-devel
mailing list