D27338: Provide an initial implementation for input-method-unstable-v1

Vlad Zahorodnii noreply at phabricator.kde.org
Thu Mar 26 15:01:35 GMT 2020


zzag added inline comments.

INLINE COMMENTS

> inputmethod_interface.cpp:128
> +    {
> +        wl_resource_destroy(resource->handle);
> +        if (resourceMap().isEmpty())

Don't call wl_resource_destroy() in foobar_destroy_resource(), it's dangerous.

  void zwp_input_method_context_v1_destroy(Resource *resource)
  {
      wl_resource_destroy(resource->handle);
  }
  
  void zwp_input_method_context_v1_destroy_resource(Resource *resource)
  {
      Q_UNUSED(resource)
      q->deleteLater();
  }

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27338

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200326/5a1f1b23/attachment.html>


More information about the Kde-frameworks-devel mailing list