D27338: Provide an initial implementation for input-method-unstable-v1

[Aleix Pol Gonzalez]

apol marked 6 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> zzag wrote in inputmethod_interface.cpp:25
> Add Q_DECL_HIDDEN.

If it makes you happy. But we're building with opt-in export symbols, it shouldn't make much of a difference.

> zzag wrote in inputmethod_interface.cpp:179
> Shouldn't `InputPanelSurfaceInterface` be also a subclass of `SurfaceRole`?

I don't know, just looked at it and it doesn't seem that useful?

> zzag wrote in inputmethod_interface.cpp:199-200
> Naming nitpick: in `FooPrivate` classes, we avoid putting `m_`.

I would rather not, otherwise when implementing private members they read like local variables.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27338

To: apol, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200326/b442b3bd/attachment-0001.html>