D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Excellent idea!
  
  I'm glad to see that the class design allows these kinds of things.

INLINE COMMENTS

> applicationlauncherjob.cpp:57
> +    d->m_service.detach();
> +    if (d->m_service) {
> +        d->m_service->setExec(serviceAction.exec());

Maybe this should even be a Q_ASSERT? We can't do much with a null service here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28285

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200325/5c1deb58/attachment-0001.html>