D28278: Move responsiblity for creating KService to CommandLauncherJob

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in kprocessrunner.cpp:119
> I //think// we can still end up with a `null` `service` through `ApplicationLauncherJob`?

I don't think so, or at least, it would be crashing already.

The constructor with the KService::Ptr uses service-> unconditionally

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28278

To: davidedmundson
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200325/9cbe0b66/attachment.html>