D28271: [KFontChooser] More code cleanup

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, cfeck, apol, bport.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  - Simplfy the layout by removing the splitter, the goal was to allow resizing the font preview text edit, which seems like an unused feature (I didn't even know that was a splitter until I read the code)
  - Remove redundant tooltips and whatisthis, IMHO it's self-explanatory
  - Move most code out of ctor to an init() method, less d-pointer redirection (and slightly more q pointer redirection)
  - Change the maximum font size from 999 to 512, which is what QFontDialog uses, personally I think neither value is realistic, but I am keeping an open mind (8K monitors?)

TEST PLAN
  kfontchooerdialogtest still works

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28271

AFFECTED FILES
  src/kfontchooser.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200325/49ad47a2/attachment-0001.html>