D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class
Ahmad Samir
noreply at phabricator.kde.org
Tue Mar 24 20:44:17 GMT 2020
ahmadsamir abandoned this revision.
ahmadsamir added a comment.
In D28193#633829 <https://phabricator.kde.org/D28193#633829>, @dfaure wrote:
> I don't think this makes any difference, they all share the same underlying private singleton.
> So all this does is to use a tiny bit more memory while the widget is up (the member var).
> The additional CPU usage without this patch or the additional memory usage with this patch are both negligible, so I can't really say which way is best.
OK, thanks for the explanation. (It seems Q{Font,Mime}Database are special in that regard).
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D28193
To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200324/0f549650/attachment.html>
More information about the Kde-frameworks-devel
mailing list