D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kfontchooserdialog.cpp:97
> hmmm..... dfaure knows more about exec() and event loops more than me. @dfaure WDYT?

The theoretical answer is yes, this would crash. But note that the user cannot just close the application by clicking somewhere while a modal dialog is up. This requires much more subtle interaction like a DBus call.

There are a million modal dialogs out there created on the stack, but sure, if you want to be pedantic, use QPointer, new (and manual delete, for lack of a proper smart pointer for this)...

(or we could set WA_DeleteOnClose instead of the manual delete? I just added a comment to the blog about that)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200324/830960bd/attachment.html>