D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> commandlauncherjobtest.cpp:3
> +    This file is part of the KDE libraries
> +    Copyright (c) 2014, 2020 David Faure <faure at kde.org>
> +

same.

> commandlauncherjobtest.h:3
> +    This file is part of the KDE libraries
> +    Copyright (c) 2014, 2020 David Faure <faure at kde.org>
> +

Should just be 2020, right?

> commandlauncherjob.cpp:50
> +    // Do *NOT* delete the KProcessRunner instances here.
> +    // We need it to keep running so it can do terminate startup notification on process exit.
> +}

s/do terminate/terminate/

REPOSITORY
  R241 KIO

BRANCH
  2020_03_commandlauncherjob

REVISION DETAIL
  https://phabricator.kde.org/D28201

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200323/bf19a121/attachment.html>