D28202: [FileIndexerConfig] Replace config QString, bool pair with dedicated class

Stefan Brüns noreply at phabricator.kde.org
Sun Mar 22 13:42:13 GMT 2020


bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  entry.path/entry.isIncluded is more readable than entry.first/enty.second.
  
  Also replace the homegrown insertSort with std::lower_bound + insert.

TEST PLAN
  ctest -R fileindexerconfigtest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28202

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200322/ccc177d3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list