D14707: autotests: skip '/' fstab check with zfs
David Faure
noreply at phabricator.kde.org
Sat Mar 21 18:12:05 GMT 2020
dfaure abandoned this revision.
dfaure added a comment.
So, this patch is wrong, and I just disabled that part of kmountpointtest on FreeBSD (https://cgit.kde.org/kio.git/commit/?id=e1ef54531ecf7dc9966860dce890201aa100c240)
The fact that KMountPoint sees no mountpoints on the FreeBSD CI (because it has no /etc/fstab) is the reason why kdirlistertest fails: it thinks the partition is "manually mounted" (like a USB key) since it's not in /etc/fstab. For that reason, kdirlister doesn't watch the partition for changes, which the test relies on.
OK, fixed by skipping "swap" in kmountpoint (https://cgit.kde.org/kio.git/commit/?id=a84f65262354aa55e67ed136a0fb0517e91aba11), and kdirlister then skips the logic of manually-mounted when there's no mountpoint at all.
https://build.kde.org/job/Frameworks/view/Platform%20-%20FreeBSDQt5.13/job/kio/job/kf5-qt5%20FreeBSDQt5.13/ is green for the first time in history. \o/
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14707
To: dfaure, adridg
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200321/944edc3e/attachment.html>
More information about the Kde-frameworks-devel
mailing list