D28144: Make animation durations consistent with Kirigami values

Nathaniel Graham noreply at phabricator.kde.org
Thu Mar 19 17:26:03 GMT 2020


ngraham created this revision.
ngraham added reviewers: Plasma, davidedmundson, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now longDuration is 120ms and shortDuration is 24ms. This presents three problems:
  
  - The durations are far too fast, especially shortDuration, which is so fast that it seems like there is no animation at all.
  - The durations are not consistent with Kirigami, which uses 150 for short and 250 for long.
  - There is no longer value available, as with the one being added to Kirigami in D28143 <https://phabricator.kde.org/D28143>.
  
  Accordingly, this patch makes the short and long values consistent with Kirigami's values,
  and adds a new `veryLongDuration` value to match the one being added to Kirigami in D28143 <https://phabricator.kde.org/D28143>.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

AFFECTED FILES
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200319/9541f5b0/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list