D26983: Enable adding place as first child
George Vogiatzis
noreply at phabricator.kde.org
Wed Mar 18 15:26:16 GMT 2020
gvgeo added a comment.
In D26983#629925 <https://phabricator.kde.org/D26983#629925>, @ngraham wrote:
> That's not how this works; reviewers being slow is not a good reason to abandon a patch. If you've lost interest in it, you can ask someone else can take it over, but just throwing away the work is pretty sad.
I'm pretty sure you misunderstood, I wouldn't abandon something because I lost interest. Reviewers being SO slow made me revisit this patch many times, each time I was seeing the same flaw in it. (Although the trigger to rethink it was different this time.)
If the code was good, it would be indeed sad. But bandaging the problems instead of fixing the core, is something that could create even more problems in the future.
The only thing I didn't like, was wasting meven's time who had taken time helping me.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26983
To: gvgeo, #frameworks, meven, broulik, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200318/1780886e/attachment.html>
More information about the Kde-frameworks-devel
mailing list