Re: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

[Ben Cooksley]

On Mon, Mar 16, 2020 at 10:24 PM David Edmundson
<david at davidedmundson.co.uk> wrote:
>
> There is not a SIC. KIO is fine
>
> It's merely this crap again:
>
> if (EXISTS "${CMAKE_SOURCE_DIR}/.git")
>    add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x060000)
>    add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000)
> endif()

May I suggest that we tweak this macro so that passing 0x060000 makes
it no-op and fail open (disabling nothing)?
We have had way too many build failures due to this.

>
> in kreversi
>
> In plasma I ported all these to:
>    add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT= kf5 version we depend on at time of release
>
> on kossebau's suggestion
>
> David

Cheers,
Ben