D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ExpandableListItem.qml:2
> It shouldn't be in PC3. It's new API from qqc2.A

Where should it live? PC2? Kirigami?

> davidedmundson wrote in ExpandableListItem.qml:23
> Unused?

Not unused, it's needed for `Highlight`, which has no PC3 version.

> davidedmundson wrote in ExpandableListItem.qml:179
> Shouldn't it run the default action?

It already does by virtue of having `defaultActionButtonAction` being an alias to `defaultActionButton.action`; this just adds an additional behavior on top of that. I'll add a comment to make this clearer

> davidedmundson wrote in ExpandableListItem.qml:230
> Seems random

Not random; this is the easing curve we agreed to and is now in the HIG: https://hig.kde.org/style/animations.html#guidelines

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200315/f4ddf202/attachment.html>