D28020: New class ProcessLauncherJob in KIOGui

David Faure noreply at phabricator.kde.org
Sun Mar 15 21:56:45 GMT 2020


dfaure updated this revision to Diff 77682.
dfaure added a comment.


  - Don't block in start(), make it fully async
  - Add waitForStarted() for KRun (with unittests)
  - Add test for non-existing executables, with and without kioexec
    - after making sure that the command isn't trivial, by starting with cd KIO::DesktopExecParser helps, though, it returns /bin/sh as such a case So we don't have to do this when the process finishes, we can check it upfront
  - Connect to QProcess::errorOccurred just for debugging (debug output in case the process crashes)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28020?vs=77547&id=77682

BRANCH
  2020_ProcessLauncherJob

REVISION DETAIL
  https://phabricator.kde.org/D28020

AFFECTED FILES
  KF5KIOConfig.cmake.in
  autotests/CMakeLists.txt
  autotests/kiotesthelper.h
  autotests/processlauncherjobtest.cpp
  autotests/processlauncherjobtest.h
  src/gui/CMakeLists.txt
  src/gui/config-kiogui.h.cmake
  src/gui/kprocessrunner.cpp
  src/gui/kprocessrunner_p.h
  src/gui/processlauncherjob.cpp
  src/gui/processlauncherjob.h
  src/widgets/CMakeLists.txt
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/krun_p.h

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200315/79068198/attachment.html>


More information about the Kde-frameworks-devel mailing list