D28039: optimize dynamic regex matching

Christoph Cullmann noreply at phabricator.kde.org
Sat Mar 14 14:27:22 GMT 2020


cullmann added a comment.


  First let's have this, the current state is bad ;=)

INLINE COMMENTS

> dhaumann wrote in rule_p.h:126
> I dislike this protected hack :-)

That is called inheritance ;=)
I first had a virtual function, but this is much easier and faster. (and just costs a few bytes)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28039

To: cullmann, dhaumann, vkrause, nibags
Cc: mwolff, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200314/40a95481/attachment.html>


More information about the Kde-frameworks-devel mailing list